Use Liquid filter in relative paths in head.html/head_print.html#788
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes local asset URL references in Jekyll head includes by wrapping bare paths in Liquid output syntax {{ "..." }}. While functionally this produces the same output as bare paths (since no filters are applied), it creates consistency with the existing pattern used for some assets like css/syntax.css. The site's flat permalink structure (all pages served from root level) means relative paths work correctly without requiring baseurl handling.
Changes:
- Wrapped 11 local asset paths in
_includes/head.htmlin Liquid output tags (favicons, CSS files, and JavaScript files) - Wrapped 18 local asset paths in
_includes/head_print.htmlin Liquid output tags (favicons, CSS files, and JavaScript files)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_includes/head.html |
Standardized 11 local asset references (images, CSS, JS) to use {{ "path" }} syntax instead of bare paths |
_includes/head_print.html |
Standardized 18 local asset references (images, CSS, JS) to use {{ "path" }} syntax instead of bare paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MakisH
added
GSoC
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Looks simple and clear, even if rather trivial. Thanks!
Seems to be originating from the documentation-theme-jekyll we are currently using.
MakisH
changed the title
Local asset references in _includes/head.html and _includes/head_print.html were using bare paths (e.g.
href="css/main.css") inconsistently alongside already-correct Liquid-filtered paths (e.g.href="{{ "css/syntax.css" }}").Bare paths silently break when Jekyll is deployed with a non-root
baseurl. Wrapping all local asset paths in{{ "..." }}ensures correct URL resolution in all deployment scenarios.Changed files:
No functional change for root deployments (like precice.org).
Closes #787